-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for DSL attribute hash keys [RFC] [Guides] #260
Conversation
# @param [Hash{Symbol=>String}] git | ||
# @option git [String] :git URI where library git repo can be cloned. | ||
# @option git [String] :tag git tag | ||
# @option git [true or false] :submodules checkout submodules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean
?
I like this! I personally feel overload is pretty spot on here. |
I'll continue on this path then, unless someone has a better idea of where and how to put the comments for the keys. |
Requesting more feedback. There is more room for improvement in other areas where we rely on examples, but I'll get to those in other PRs. Now to try and get it in guides. |
don't worry about getting it in the guides, every CP release it will be automatically migrated in, |
Overall looks good to me, more docs is 👍 |
Improve documentation for DSL attribute hash keys [RFC] [Guides]
@Ashton-W good work 👍 |
@orta guides doesn't surface these particular documentation tags yet |
@Ashton-W because we haven't cut a new release of CocoaPods yet ;) |
I'm running guides locally with the Core gem pointing to my fork. @Overloads and @options don't show up. |
You've updated the Core submodule in |
OK, thanks for opening the issue over there, I'll try and take a look before I release the 0.39 beta |
Improve documentation for DSL attribute hash keys [RFC] [Guides]
I want to improve the Guides for the DSLs. Currently they don't list the acceptable hash keys, there are only examples from which you can gleam this important information.
https://guides.cocoapods.org/syntax/podspec.html#source
I'm trying to find a good pattern to get this information into the documentation system, then we will also have to update guides.cocoapods.org to format and include it. Right now I'm just using
yard
to see how it picks up the comments.Idealy, we shouldn't have to repeat ourselves. Where we define the options should be where the documentation is. I'm finding it hard to do this, and I'm not happy with the
@overload
usage here.🐦 @orta