Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alloy => Initial work on YARDOC changes in for Podfile DSL #32

Merged
merged 3 commits into from
Oct 21, 2013

Conversation

orta
Copy link
Member

@orta orta commented Oct 21, 2013

Nothing crazy, looks like I'll be doing work mostly with respect to removing HRs and expanding on group descriptions.

//cc @irrationalfab

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bd34b85 on orta:master into 866e8ed on CocoaPods:master.

@@ -45,21 +50,17 @@ module DSL
# A dependency requirement is defined by the name of the Pod and
# optionally a list of version requirements.
#
# ------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, that’s my line!

Ba-dum-tsh ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alloy
Copy link
Member

alloy commented Oct 21, 2013

👍

orta added a commit that referenced this pull request Oct 21, 2013
@alloy => Initial work on YARDOC changes in for Podfile DSL
@orta orta merged commit 4769d4a into CocoaPods:master Oct 21, 2013
# The Podfile specifies the dependencies of each user target.
#
# * `pod` is the way to declare a specific dependency.
# * `podspec` provides an easy creation API for local podspecs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local is a term that I would prefer to avoid, moreover you can specify the url of a remote podspec as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair, makes sense, will change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎱

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@fabiopelosin
Copy link
Member

👍

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
@alloy => Initial work on YARDOC changes in for Podfile DSL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants