Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default_subspec for nested subspec #65

Closed
wants to merge 1 commit into from

Conversation

stephanecopin
Copy link

Fixes CocoaPods/CocoaPods#1021 which has been around for a long time now.

@kylef
Copy link
Contributor

kylef commented Mar 20, 2014

Could you throw in a regression test for good measure?

@alloy
Copy link
Member

alloy commented Mar 20, 2014

@kylef 👍

@fabiopelosin
Copy link
Member

bump

@stephanecopin
Copy link
Author

Sure, I'll try to make one asap (Sorry for the late reply, I'm being kinda busy at the moment)

@fabiopelosin
Copy link
Member

@Tif-tof do you want me to take care of finishing this?

@fabiopelosin
Copy link
Member

The proposed patch was not merged because the Specification#subspec_dependencies method is expected to return full specification names (as that information is used by the resolver).

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default_subspec for nested subspecs
4 participants