Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make richer version conflict messages possible #24

Merged
merged 2 commits into from
Jul 23, 2015

Conversation

segiddins
Copy link
Member

@indirect
Copy link

👍

@alloy
Copy link
Member

alloy commented Jul 21, 2015

Nice 👍

@segiddins
Copy link
Member Author

I'm kinda tempted to use this and make the tree-style output Bundler uses a builtin method on VersionConflict, something like tree_message. How does that sound?

@indirect
Copy link

I'm for it, but I designed the Bundler output. 😅

@alloy
Copy link
Member

alloy commented Jul 21, 2015

Just to be clear we’re on the same page, can you provide examples of the output?

@segiddins
Copy link
Member Author

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    jquery-rails, resolved to 4.0.4 depends on
      railties (>= 4.2.0)

    rails-i18n, resolved to 4.0.4 depends on
      railties (~> 5.0)

    rails, resolved to 5.0.0.alpha depends on
      railties (= 5.0.0.alpha)

    codemirror-rails (= 4.2), resolved to 4.2 depends on
      railties (< 5, >= 3.0)

    rspec-rails (~> 2.14.0), resolved to 2.14.2 depends on
      railties (>= 3.0)

Could not find gem 'railties (~> 5.0)', which is required by gem 'jquery-rails', in any of the sources.

@segiddins
Copy link
Member Author

(The code that generates that is pretty much https://github.com/bundler/bundler/blob/master/lib/bundler/resolver.rb#L13-L68)

@alloy
Copy link
Member

alloy commented Jul 21, 2015

Ok cool, yeah I like this message 👍

I’m less a fan of repeating the name of the dependency (railties) over and over, but maybe there’s a reason for that?

@segiddins
Copy link
Member Author

@alloy reason for the repeated name is specific to this example, where lots of things had dependencies on railties. Note, I'm not suggesting making this format the default (because it requires a few parameters from the user), but I do think building it in would be nice.

@alloy
Copy link
Member

alloy commented Jul 21, 2015

Gotcha. I think it’s a good idea, do it 👍

segiddins added a commit that referenced this pull request Jul 23, 2015
Make richer version conflict messages possible
@segiddins segiddins merged commit a5f30b6 into master Jul 23, 2015
@segiddins segiddins deleted the seg-filter-requirement-trees branch July 23, 2015 03:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants