Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error in pod spec #9489

Merged
merged 1 commit into from Mar 21, 2014
Merged

Fixed error in pod spec #9489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion M13BadgeView/1.0.0/M13BadgeView.podspec
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI

s.source_files = 'Classes/*'

s.frameworks = 'Foundation, QuartzCore'
s.frameworks = 'Foundation', 'QuartzCore'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, maybe the linter could catch this kind of thing (invalid characters inside a framework/library etc).

/cc @kapin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, that's a weird one. I think once I get this school monster off my back I can throw together a nice regex to filter out this fun stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be simple as to not allow anything but normal characters in the strings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created CocoaPods/Core#66 to track this.


s.requires_arc = true
end