Skip to content
This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Images with spaces in their path are not rendered correctly #376

Open
xhacker opened this issue Aug 10, 2015 · 7 comments
Open

Images with spaces in their path are not rendered correctly #376

xhacker opened this issue Aug 10, 2015 · 7 comments

Comments

@xhacker
Copy link

xhacker commented Aug 10, 2015

See the second image in http://cocoadocs.org/docsets/TagListView/0.2/, and the corresponding GitHub page https://github.com/xhacker/TagListView.

I'm guessing something is wrong here https://github.com/CocoaPods/cocoadocs.org/blob/master/classes/readme_manipulator.rb#L44, but I'm not really familiar with ruby.

@orta
Copy link
Member

orta commented Aug 15, 2015

Interesting, thanks for the report

@segiddins
Copy link
Member

Yup, the issue there is that the html already has the space encoded as %20, so it gets re-encoded to %2520, which is wrong

@stale
Copy link

stale bot commented Oct 10, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 10, 2017
@xhacker
Copy link
Author

xhacker commented Oct 10, 2017

Bump.

@stale stale bot removed the stale label Oct 10, 2017
@stale
Copy link

stale bot commented Nov 9, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@xhacker
Copy link
Author

xhacker commented Nov 9, 2017

This is not stale. The issue still exists.

@stale
Copy link

stale bot commented Dec 14, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants