Also rescue Errno::EHOSTDOWN in send method #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @clemensg looks great - any chance you can add this to the CHANGELOG too please? |
|
Sure, one moment. |
clemensg
force-pushed
the
rescue_errno_hostdown
branch
from
59af40b
to
196f5e5
Compare
|
Imo this change belongs upstream in nap |
Otherwise `pod setup` fails, just because the stats upload is blocked. This happens when using a strict firewall or something like LittleSnitch on OS X. Signed-off-by: Clemens Gruber <clemensgru@gmail.com>
clemensg
force-pushed
the
rescue_errno_hostdown
branch
from
196f5e5
to
0481c35
Compare
|
@segiddins OK, I can try fixing it there. |
|
@alloy ^ |
|
My fix was just merged upstream! |
|
ace, we just need this updated in CocoaPods - which exposes it for stats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
pod setupfails, just because the stats upload is blocked.This can happen behind a firewall or when using something like LittleSnitch on OS X.
Signed-off-by: Clemens Gruber clemensgru@gmail.com