Deal with Github repo redirects #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,8 +84,7 @@ def handle_update_error(e, pod) | |||
| when /404 Not Found/ | |||
| not_found(pod) | |||
| when /403 API rate limit exceeded/ | |||
| headers = ::Github::Response::Headers.new response_headers: e.http_headers | |||
|
|
|||
| headers = ::Github::Response::Header.new response_headers: e.http_headers | |||
There was a problem hiding this comment.
There is no Headers class only Header, this was being masked by the raise in updater.rb
This was referenced Aug 23, 2015
| @@ -41,6 +41,11 @@ begin | |||
| exec 'bundle exec kicker -c' | |||
| end | |||
|
|
|||
| desc 'Update metrics for a pod' | |||
| task :update, [:name] do |t, args| | |||
| exec "bundle exec ruby updater.rb #{ args[:name] }" | |||
|
doing it 🍏 |
| @@ -22,6 +22,7 @@ Metrics is an API to view metrics for Pods. | |||
| + Attributes | |||
| + github (GitHub Metrics) | |||
| + cocoadocs (CocoaDoc Metrics) | |||
| + stats (CocoaPods Stats Metrics) | |||
There was a problem hiding this comment.
http://metrics.cocoapods.org/api/v1/status has github and cocoadocs, should it also have stats now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting crashes that stopped the github metrics grabbing caused by redirects. It was difficult to run just one metric, so I added a rake task for it.