-
Notifications
You must be signed in to change notification settings - Fork 11
Results for name with subspec are empty #65
Comments
Go ahead. |
Hmm, maybe I misunderstood. You mean that the expression A/B should have special significance? |
Yes, as spec: 'A',
subspec: 'B', |
I'm not sure whether the subspecs should have special significance - I don't know the domain well enough. Ping others? |
@segiddins But I'd be definitely happy if you split on '/', for a start :) |
Where should I look to be making that sort of change? -Samuel E. Giddins On Nov 5, 2014, at 11:34 PM, Florian R. Hanke notifications@github.com wrote: @segiddins But I'd be definitely happy if you split on '/', for a start :) — |
In two places (and maybe remove the duplication): To run the tests you need to load |
@floere after thinking it through, I believe the correct approach would be to make the recursive subspecs searchable |
As a separate category? So if you search for CoreData, then RestKit should be found via CoreData under category subspecs? |
Yes, but shouldn't it also match the name, but with a lower weight than matching the root spec's name? |
Not sure I understand fully. Can we make an example? (
"name"=>"AFNetworking",
"version"=>"2.3.1",
"license"=>"MIT",
"summary"=>"A delightful iOS and OS X networking framework.",
"homepage"=>"https://github.com/AFNetworking/AFNetworking",
"social_media_url"=>"https://twitter.com/AFNetworking",
"authors"=>{"Mattt Thompson"=>"m@mattt.me"},
"source"=>{
"git"=>"https://github.com/AFNetworking/AFNetworking.git",
"tag"=>"2.3.1",
"submodules"=>true},
"requires_arc"=>true,
"platforms"=>{
"ios"=>"6.0",
"osx"=>"10.8"
},
"public_header_files"=>"AFNetworking/*.h",
"source_files"=>"AFNetworking/AFNetworking.h",
"subspecs"=>[
{
"name"=>"Serialization",
"source_files"=>"AFNetworking/AFURL{Request,Response}Serialization.{h,m}",
"ios"=>{
"frameworks"=>[
"MobileCoreServices",
"CoreGraphics"
]
},
"osx"=>{
"frameworks"=>"CoreServices"
}
},
{
"name"=>"Security",
"source_files"=>"AFNetworking/AFSecurityPolicy.{h,m}",
"frameworks"=>"Security"}, {"name"=>"Reachability",
"source_files"=>"AFNetworking/AFNetworkReachabilityManager.{h,m}",
"frameworks"=>"SystemConfiguration"
},
{
"name"=>"NSURLConnection",
"dependencies"=>{
"AFNetworking/Serialization"=>[],
"AFNetworking/Reachability"=>[],
"AFNetworking/Security"=>[]
},
"source_files"=>[
"AFNetworking/AFURLConnectionOperation.{h,m}",
"AFNetworking/AFHTTPRequestOperation.{h,m}",
"AFNetworking/AFHTTPRequestOperationManager.{h,m}"
]
},
{
"name"=>"NSURLSession",
"dependencies"=>{
"AFNetworking/Serialization"=>[],
"AFNetworking/Reachability"=>[],
"AFNetworking/Security"=>[]
},
"source_files"=>[
"AFNetworking/AFURLSessionManager.{h,m}",
"AFNetworking/AFHTTPSessionManager.{h,m}"
]
},
{
"name"=>"UIKit",
"platforms"=>{
"ios"=>"6.0"
},
"dependencies"=>{
"AFNetworking/NSURLConnection"=>[],
"AFNetworking/NSURLSession"=>[]
},
"ios"=>{
"public_header_files"=>"UIKit+AFNetworking/*.h",
"source_files"=>"UIKit+AFNetworking"
},
"osx"=>{
"source_files"=>""
}
}
]
) Should this pod be found when entering |
Yes, imho -Samuel E. Giddins On Nov 6, 2014, at 1:23 PM, Florian R. Hanke notifications@github.com wrote: Not sure I understand fully. Can we make an example? ( — |
I'm my opinion, yes. |
Under category "subspecs"? I'm just not sure I understand the use case fully – a user wants to find AFNetworking, but does not know the name. But they remember that a subspec of it was "Serialization", so they enter that. Does that make sense? |
Should we make this: |
Ping |
Can I close this? We're not making any progress. |
I will make progress, I promise. I just dropped the ball on this -Samuel E. Giddins On Dec 22, 2014, at 7:16 AM, Florian R. Hanke notifications@github.com wrote: Can I close this? We're not making any progress. — |
No worries! I'd just like to reduce the issue count. It's not urgent :) On Mon, Dec 22, 2014 at 11:20 AM, Samuel E. Giddins
|
See http://cocoapods.org/?q=RestKit%2FCoreData
@floere I'd love to start by at least splitting on the
/
, but maybe the subspec names should also be taken into account when searching?The text was updated successfully, but these errors were encountered: