Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send commit in Tendermint #1761

Closed
majecty opened this issue Sep 5, 2019 · 1 comment
Closed

Send commit in Tendermint #1761

majecty opened this issue Sep 5, 2019 · 1 comment
Labels
bug Something isn't working consensus

Comments

@majecty
Copy link
Contributor

majecty commented Sep 5, 2019

Currently, we send the best proposal block in the sync extension to deliver block's precommits.
However, if the first proposer is not following the best block, there is no best proposal block.

We need other methods to send committed precommits.
@majecty majecty added bug Something isn't working consensus labels Sep 5, 2019
@majecty
Copy link
Contributor Author

majecty commented Sep 18, 2019

Implemendted at #1770

@majecty majecty closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working consensus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majecty