Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinia-orm): Query constraints with nested relations in m:m relations broken #625

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented Nov 25, 2022

πŸ”— Linked issue

closes #623

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the bug Something isn't working label Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 99.73% // Head: 99.73% // No change to project coverage πŸ‘

Coverage data is based on head (44cfaf1) compared to base (c09045a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          83       83           
  Lines        5289     5289           
  Branches      481      481           
=======================================
  Hits         5275     5275           
  Misses         14       14           
Impacted Files Coverage Ξ”
...rm/src/model/attributes/relations/BelongsToMany.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd changed the base branch from master to next-release November 28, 2022 12:26
@CodeDredd CodeDredd merged commit baf0304 into next-release Nov 28, 2022
@CodeDredd CodeDredd deleted the pinia-orm-623 branch November 28, 2022 12:27
@CodeDredd CodeDredd mentioned this pull request Nov 28, 2022
CodeDredd added a commit that referenced this pull request Dec 6, 2022
* fix(pinia-orm): Query constraints with nested relations in m:m relations broken (#625)

* fix(pinia-orm): Query constraints with nested relations in m:m relations broken

* refactor(pinia-orm): remove skip in test

* feat(pinia-orm): Add the option to sort case insensitive with `sortBy` (#636)

* docs(pinia-orm): Add requirements info for nuxt 2 users (#638)

* refactor(normalizr): reduce code to only used by orm (#641)

* perf(pinia-orm-659): Save hydrated models if not updated (#671)

* perf(pinia-orm-659): Save hydrated models if not updated

* refactor(pinia-orm): typo

closes #659, #623, #628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subrelations broken after many to many
2 participants