perf(pinia-orm-659): Save hydrated models if not updated #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Merged
CodeDredd
added a commit
that referenced
this pull request
Dec 6, 2022
* fix(pinia-orm): Query constraints with nested relations in m:m relations broken (#625) * fix(pinia-orm): Query constraints with nested relations in m:m relations broken * refactor(pinia-orm): remove skip in test * feat(pinia-orm): Add the option to sort case insensitive with `sortBy` (#636) * docs(pinia-orm): Add requirements info for nuxt 2 users (#638) * refactor(normalizr): reduce code to only used by orm (#641) * perf(pinia-orm-659): Save hydrated models if not updated (#671) * perf(pinia-orm-659): Save hydrated models if not updated * refactor(pinia-orm): typo closes #659, #623, #628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #659, related vuex-orm/vuex-orm#746
❓ Type of change
📚 Description
Right now if any action is called every model is new hydrated which triggers an update event if you have child components
using the model.
With this change hydrated models are saved and only updated if they change, so thate no rerender is triggered.
📝 Checklist