Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pinia-orm): Add the option to sort case insensitive with sortBy #636

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

CodeDredd
Copy link
Owner

@CodeDredd CodeDredd commented Nov 28, 2022

πŸ”— Linked issue

#634

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adding the option to sort collections case insensitive:

const userCollection = useCollect(useRepo(User).make([
    { id: 1, name: 'James', age: 40, post: { id: 1, title: 'Title1' } },
    { id: 2, name: 'john', age: 30, post: { id: 2, title: 'Title2' } },
    { id: 3, name: 'David', age: 20 },
  ])).sortBy('name', 'SORT_FLAG_CASE')

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the enhancement New feature or request label Nov 28, 2022
@CodeDredd CodeDredd self-assigned this Nov 28, 2022
@CodeDredd CodeDredd changed the base branch from master to next-release November 28, 2022 12:28
@CodeDredd CodeDredd merged commit eb6e3c4 into next-release Nov 28, 2022
@CodeDredd CodeDredd deleted the sortby-enhance branch November 28, 2022 12:28
@CodeDredd CodeDredd mentioned this pull request Nov 28, 2022
CodeDredd added a commit that referenced this pull request Dec 6, 2022
* fix(pinia-orm): Query constraints with nested relations in m:m relations broken (#625)

* fix(pinia-orm): Query constraints with nested relations in m:m relations broken

* refactor(pinia-orm): remove skip in test

* feat(pinia-orm): Add the option to sort case insensitive with `sortBy` (#636)

* docs(pinia-orm): Add requirements info for nuxt 2 users (#638)

* refactor(normalizr): reduce code to only used by orm (#641)

* perf(pinia-orm-659): Save hydrated models if not updated (#671)

* perf(pinia-orm-659): Save hydrated models if not updated

* refactor(pinia-orm): typo

closes #659, #623, #628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant