NW6 | Orlando_Morales | JS2_Module_Todo-List | Week3 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into JS2-Week3-quotegenerator
… into JS2-Week3-todolist
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bunday
suggested changes
Jan 27, 2024
| <div class="wrapper"> | ||
| <header>Todo-List</header> | ||
| <div class="inputField"> | ||
| <input type="text" placeholder="Add your new Todo" /> |
There was a problem hiding this comment.
user's should enter the todo, and also set the deadline date, the date input field is missing
| </ul> | ||
| <div class="footer"> | ||
| <span>You have <span class="pendingTasks"></span> pending tasks</span> | ||
| <button>Clear All</button> |
There was a problem hiding this comment.
we don't need a clear all button from the requirements, we need a "Clear Completed Todo" button/feature
| const todoList = document.querySelector(".todoList"); | ||
| const deleteAllBtn = document.querySelector(".footer button"); | ||
|
|
||
| inputBox.onkeyup = () => { |
|
|
||
| // These are the same todos that currently display in the HTML | ||
| // You will want to remove the ones in the current HTML after you have created them using JavaScript | ||
| let todos = [ |
There was a problem hiding this comment.
by default, these tasks should be displayed on the home page
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.