NW6| Bakhat Begum | MODULE-JS2| Js2 slideshow/week 4 | Week-4 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
Honestocean
reviewed
Feb 3, 2024
There was a problem hiding this comment.
Great Job, you've managed to get all the strech functionality, including making sure that the auto-forward/backward buttons cannot be pressed multiple times. The code could do with some simplifying, use fewer array methods like shift and push, look out for repeated code.
|
|
||
| document.getElementById('next').addEventListener('click', (event) => { | ||
| img_list.push(img_list.shift()); |
There was a problem hiding this comment.
This is an interesting use of array methods to access the image and add it to the document. Consider simplifying by accessing the desired element in the array with bracket notation
|
|
||
| let autoForwardButton = false; | ||
| setInterval(() => { |
There was a problem hiding this comment.
You already have a set interval, consider refactoring this code into the same place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
the task is to caracole images and have control images by buttons. when the user clicks auto-forward the image should change forward after every 5 seconds and when the user clicks the auto-backwards button, the image should change backwards after every 5 seconds. Secondly, when the user clicks the stop button it must stop the image caracole from auto mode. Lastly, image movement must be controlled by forward and backward buttons.
Questions