Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding log from Yii to artifacts when test fails #8

Merged
merged 1 commit into from Jun 17, 2022
Merged

Adding log from Yii to artifacts when test fails #8

merged 1 commit into from Jun 17, 2022

Conversation

aywan
Copy link
Contributor

@aywan aywan commented Apr 9, 2020

No description provided.

@aywan aywan mentioned this pull request Apr 9, 2020
Closed
@SamMousa
Copy link
Collaborator

I'm going to close & reopen this. Hopefully it will then allow the new CI to run properly!

@SamMousa SamMousa closed this May 12, 2020
@SamMousa SamMousa reopened this May 12, 2020
@aywan
Copy link
Contributor Author

aywan commented Jun 15, 2020

I will try to fix tests soon

@samdark
Copy link
Collaborator

samdark commented Dec 21, 2020

@aywan would you please merge master into the PR branch. Tests are now in order with GitHub actions in place.

@SamMousa
Copy link
Collaborator

SamMousa commented Jan 2, 2021

This breaks BC, since the nullable argument is not optional.
Other than that I like the idea

@aywan
Copy link
Contributor Author

aywan commented Jan 2, 2021

Why tests are in external repo?

@SamMousa
Copy link
Collaborator

SamMousa commented Jan 2, 2021

Because the module wasn't, originally.. Since codeception modules have been split to separate repos, we could merge the tests back into this one.

@DBX12
Copy link
Contributor

DBX12 commented Oct 16, 2021

Off-topic for this pull request: I would really like to see the tests in the module repo as well. It was confusing to clone the repo and see no tests folder the first time :D

@SamMousa
Copy link
Collaborator

A PR moving them would be greatly appreciated!

@DBX12 DBX12 mentioned this pull request Oct 26, 2021
Merged
@samdark
Copy link
Collaborator

samdark commented Nov 26, 2021

So now tests are moved.

@developedsoftware
Copy link

Can this be merged?

@samdark samdark merged commit cfb21a7 into Codeception:master Jun 17, 2022
@samdark
Copy link
Collaborator

samdark commented Jun 17, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aywan @SamMousa @samdark @DBX12 @developedsoftware