-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual improvements for 3.0 #2981
Conversation
I have a suggestion that can be made on this PR: The default value for all rows on the header/footer builder could be the site background instead of white. This can avoid some misunderstandings for users since it'll change color when using the palette switcher. |
@gutoslv They already default to the site background color 👀 |
When the content width is not filled, the sidebar will not appear. This commit address this issue.
@abaicus In the Classic Editor, the layout settings from Neve are overriding the setting from Classic Editor on a specific post, that's why the Cypress test related to the page editor on Classic Editor is failing. May you take a look at this issue? For example: when you set content width to be 70% on a specific page, and the Content Width is set to 50% on the Customizer of Neve, then the 50% of Neve will work for every page even if the content width for a specific page is set on the classic editor.. This doesn't happen on the Guttenberg editor, only with the Classic editor active. |
chore: make sure we take into account meta value for hiding the sidebar when content width is > 94%
…inside customizer
@gutoslv this should be in working order now 🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Will affect visual aspect of the product
YES
Screenshots
Test instructions
These changes should be enabled on the new skin.
Closes #2978, closes #1363.