Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual improvements for 3.0 #2981

Merged
merged 12 commits into from
Jul 27, 2021
Merged

Visual improvements for 3.0 #2981

merged 12 commits into from
Jul 27, 2021

Conversation

abaicus
Copy link
Collaborator

@abaicus abaicus commented Jul 26, 2021

Summary

  • change spacing on post meta
  • add margin to li tags in content
  • revise typographic scale
  • change defaults for sidebar layout, content width and blog layout
  • disable sidebar when content width is larger than 94%
  • fix new widgets search form style
  • fix condition for showing style customizer section

Will affect visual aspect of the product

YES

Screenshots

Test instructions

These changes should be enabled on the new skin.

Closes #2978, closes #1363.

@github-actions
Copy link

github-actions bot commented Jul 26, 2021

Plugin build for a474f7a is ready 🛎️!

@abaicus abaicus mentioned this pull request Jul 26, 2021
@gutoslv
Copy link
Contributor

gutoslv commented Jul 26, 2021

I have a suggestion that can be made on this PR: The default value for all rows on the header/footer builder could be the site background instead of white. This can avoid some misunderstandings for users since it'll change color when using the palette switcher.

@abaicus
Copy link
Collaborator Author

abaicus commented Jul 26, 2021

@gutoslv They already default to the site background color 👀

When the content width is not filled, the sidebar will not appear. This commit address this issue.
@gutoslv
Copy link
Contributor

gutoslv commented Jul 27, 2021

@abaicus In the Classic Editor, the layout settings from Neve are overriding the setting from Classic Editor on a specific post, that's why the Cypress test related to the page editor on Classic Editor is failing. May you take a look at this issue?

For example: when you set content width to be 70% on a specific page, and the Content Width is set to 50% on the Customizer of Neve, then the 50% of Neve will work for every page even if the content width for a specific page is set on the classic editor.. This doesn't happen on the Guttenberg editor, only with the Classic editor active.

chore: make sure we take into account meta value for hiding the sidebar when content width is > 94%
@selul selul merged commit c908f70 into development Jul 27, 2021
@selul selul deleted the visual-improvements branch July 27, 2021 11:25
@abaicus
Copy link
Collaborator Author

abaicus commented Jul 27, 2021

@gutoslv this should be in working order now 🚀

@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants