Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode not working properly with the new skin on starter sites #2959

Closed
gutoslv opened this issue Jul 14, 2021 · 6 comments
Closed

Dark mode not working properly with the new skin on starter sites #2959

gutoslv opened this issue Jul 14, 2021 · 6 comments
Assignees
Labels
neve-30 regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@gutoslv
Copy link
Contributor

gutoslv commented Jul 14, 2021

Description:

On some starter sites (tests with Web Archive and Shop)

How to reproduce:

  1. Install Neve 3.0
  2. Import any site from starter sites
  3. Toggle dark mode (manually or with the palette switcher component)

Expected behavior:

The text is readable and in contrast with the background. You can check it here

Current behavior:

The color of the text gets mixed with the background. You can check it here

Reference:

https://vertis.d.pr/FYbJrC - Old Skin working as expected
https://vertis.d.pr/D9J2tP - New Skin with the bug

Website to reproduce: https://disgusted-whitefish.jurassic.ninja/wp-admin
user: demo
pwd: Unf08vnAfMpm

Technical info

  • WordPress version: 5.7.2
  • Theme version: 3.0.0
@gutoslv gutoslv added neve-30 regression Issue represents a change in behavior from a previous version that is not intended or desired.. labels Jul 14, 2021
@gutoslv
Copy link
Contributor Author

gutoslv commented Jul 14, 2021

My 2 cents is that it's related to CSS variables since the colors still the same on the Customizer > Colors & Background > Dark Modemenu.

What do you think that it might be @abaicus?

@mghenciu
Copy link

Also related to Dark Mode:

  • When an user imports Elementor demos with Neve 3, and adds the Palette Switcher to the Nav, the Switcher doesn't works as expected (see the error in console)
    image

Video: https://www.loom.com/share/452c4b3fd2224b169ab1285b28e4d291

The Repro Rate is low, meaning that it doesn't happen on all Elementor demos. So far I found it happening on Fitness & Freelancer demos. Not sure what this demos have special.

Repro:

  1. Install Neve 3
  2. Import the Elementor Fitness demo
  3. Add the Palette Switcher to the Nav
  4. Use the Palette Switcher on the live site

@gutoslv
Copy link
Contributor Author

gutoslv commented Jul 24, 2021

@abaicus the behavior that @mghenciu reported still happening. On other starter sites, it works fine now.

@abaicus
Copy link
Collaborator

abaicus commented Jul 26, 2021

@gutoslv Thanks for reporting it! This should be in working order inside this PR. 👍🏻

@gutoslv
Copy link
Contributor Author

gutoslv commented Jul 26, 2021

Tested and it's fixed now. Thanks for taking care of that!

@abaicus abaicus closed this as completed in 092cd4f Aug 4, 2021
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neve-30 regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

No branches or pull requests

4 participants