Home page #39
Merged
Home page #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santakadev
force-pushed
the
home-page
branch
2 times, most recently
from
ff52e7d
to
819424c
Compare
santakadev
force-pushed
the
home-page
branch
4 times, most recently
from
76d9268
to
d5a7548
Compare
JavierCane
approved these changes
Apr 29, 2019
src/index.js
Outdated
| @@ -24,14 +30,14 @@ class P2PEditor { | |||
| window.history.pushState(null, null, sessionId) | |||
| } | |||
| }) | |||
|
|
|||
| this.session.on('session.new_peer_appeared', (peer) => { | |||
| this.changeLog.replicate(peer, {live: true, encrypt: false}) | |||
| // eslint-disable-next-line no-console | |||
| console.log('new peer') | |||
There was a problem hiding this comment.
Given that right now this is a stable feature, could we remove this console.log?
There was a problem hiding this comment.
Sure! thanks for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A home page when accesing to P2P Editor. This home page is the base for future sessión configuration like, set display name (See #7), Enabling/disabling audio before accesing, type of session (See wiki), etc.
There are two versions of home page:
I don't want to put too much effort on design right now, so I have use a very basic style.
Integration: https://p2p-editor.codely.tv/ (browser cache flush needed if previously visited the old version)
Why
I've implemented #7 in local with the new proposed architecture #37. The feature is working but I have pending:
I've decided to split the task and create this one first.