-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page #39
Home page #39
Conversation
ff52e7d
to
819424c
Compare
76d9268
to
d5a7548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🙌
Gogogoooooo 🚀
src/index.js
Outdated
@@ -24,14 +30,14 @@ class P2PEditor { | |||
window.history.pushState(null, null, sessionId) | |||
} | |||
}) | |||
|
|||
this.session.on('session.new_peer_appeared', (peer) => { | |||
this.changeLog.replicate(peer, {live: true, encrypt: false}) | |||
// eslint-disable-next-line no-console | |||
console.log('new peer') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that right now this is a stable feature, could we remove this console.log
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! thanks for the feedback!
What
A home page when accesing to P2P Editor. This home page is the base for future sessión configuration like, set display name (See #7), Enabling/disabling audio before accesing, type of session (See wiki), etc.
There are two versions of home page:
I don't want to put too much effort on design right now, so I have use a very basic style.
Integration: https://p2p-editor.codely.tv/ (browser cache flush needed if previously visited the old version)
Why
I've implemented #7 in local with the new proposed architecture #37. The feature is working but I have pending:
I've decided to split the task and create this one first.