Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ayo as a Mentor #238

Merged
merged 7 commits into from Apr 9, 2019

Conversation

Developerayo
Copy link
Contributor

No description provided.

Added Ayo as a Mentor
@moshfeu moshfeu added the waiting for fix Waiting for fix a PR label Apr 2, 2019
@devictoribero
Copy link
Contributor

devictoribero commented Apr 2, 2019

As you can see the build is failing: https://travis-ci.com/Coding-Coach/find-a-mentor/builds/106640235

Please fix those errors and if need help as for it!

@Developerayo
Copy link
Contributor Author

Developerayo commented Apr 2, 2019

Yes, I'm aware of this, been quite a busy week, ill get to this before the week runs out @tureey !

@Developerayo
Copy link
Contributor Author

I'll get to this soon

@Developerayo
Copy link
Contributor Author

Or if anyone can help :)

@moshfeu
Copy link
Member

moshfeu commented Apr 3, 2019

I'll try to help:

  1. You have too much labels (you can only 5) https://github.com/Coding-Coach/find-a-mentor/pull/238/files#diff-8e81e28d72365fb78a7ee4a47ff26c6fR3689.
  2. You was split you schema, I'm not sure why : https://github.com/Coding-Coach/find-a-mentor/pull/238/files#diff-8e81e28d72365fb78a7ee4a47ff26c6fR3926.

Maybe, it will be better to delete this PR and use the cli. It will helps you to do it right.

@brockneedscoffee
Copy link
Member

@Developerayo I fixed your mentors.json file and it passes the test. See below. I had to remove a few tags and channels so double check you like the values before you put it in your branch and commit. This will fix your issues though. Looks like you accidentally pasted your twitter name in another object, added too many tags, and a few other gotchas.

see link to gist
https://gist.github.com/brockmdavis/6425fb90ebb4be7b02b282f9e02ffa25

cc: @moshfeu

@moshfeu
Copy link
Member

moshfeu commented Apr 5, 2019

@brockmdavis thanks!

@Developerayo
Copy link
Contributor Author

Developerayo commented Apr 5, 2019

Thanks, @brockmdavis @moshfeu

Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@moshfeu moshfeu merged commit cc16729 into Coding-Coach:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for fix Waiting for fix a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants