Add support for !rgb command compression #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to read compressed !rgb commands where the colours can be either a raw colour or an index of an existing colour.
i.e. if the first colour is red then the second green then the third red
!rgb ff0000,00ff00,ff0000rather than repeat the red colour again we can use a back-reference.
!rgb ff0000,00ff00,*0meaning the third colour is the same as the first.The
*denotes a back reference.Two upsides is that this still supports the old format for anyone who wants to write the raw command. And the compressed format will never be larger than the original even if no colour is repeated as it will just be the same as if we had not compressed it.
The mirrored pull-request on react-pixel-art-maker can be found here