Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Tags #796

Merged
merged 8 commits into from
Nov 26, 2022
Merged

Cleanup Tags #796

merged 8 commits into from
Nov 26, 2022

Conversation

dipamsen
Copy link
Member

@dipamsen dipamsen commented Nov 25, 2022

Removes duplicate language tags.

(Related: #488)

selector

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit dadf0e0
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/638113425402d70009c54b47
😎 Deploy Preview https://deploy-preview-796--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shiffman
Copy link
Member

Oh fantastic, can any of #489 be incorporated too or is that separate?

@fturmel
Copy link
Collaborator

fturmel commented Nov 25, 2022

Interesting timing, I was just about to ask if I could pick up #489. Should I still? I think it's very powerful to have a bulk normalizing / grouping / renaming pass when the Gatsby nodes get created for both topics and languages in addition to correcting the sources when possible.

@shiffman
Copy link
Member

Yes, I'd love to do both! I'm traveling today so can't easily review and merge things, but will be back online later tonight / tomorrow.

@dipamsen
Copy link
Member Author

@fturmel Just in case this is helpful, here are the original variations of languages which I have normalised (with the currently used versions at the beginning):

p5.js / p5js
ml5.js / ml5
Java / java
Processing / processing
JavaScript / javascript / Javascript
node.js / Node.js

@fturmel
Copy link
Collaborator

fturmel commented Nov 25, 2022

@dipamsen Thanks for that!

@shiffman
Copy link
Member

I'm going to go ahead and merge this and we can tackle #489 next! @fturmel if you work on it would you mind forking that branch so that @M0nica's commits are included in the repo history? Thank you!!

@shiffman shiffman merged commit d2cb3a2 into CodingTrain:main Nov 26, 2022
@dipamsen dipamsen deleted the cleanup-tags branch November 26, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants