Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow derived class content to be serialized/deserialized correctly in all publishers #172

Open
jeremyiverson opened this issue Jan 25, 2018 · 3 comments
Labels

Comments

@jeremyiverson
Copy link
Member

  • XML: Choice group, with name = $"{ConcreteTypeName}{PropertyName}"
  • JSON: Output type property with the concrete type name
@DanSmith
Copy link
Member

DanSmith commented May 8, 2018

for xml publisher, also investigate using xsi:type declarations

@DanSmith
Copy link
Member

DanSmith commented Oct 2, 2018

As of e677cf3 the json schema, csharp, and csharp json serializer support this. Xml and csharp json deserialization are still to be done.

The on disk format of the csv must be updated to the current version with new columns by running the cogs rewrite command, and the AllowSubtypes column for a property should be set to true where type discriminators are to be allowed.

@DanSmith
Copy link
Member

DanSmith commented Oct 3, 2018

As of 4f736e2 the csharp target will parse type discriminated json.

Review of XML is still needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants