-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug & Request]: Things I found while entirely revising fr-FR localization & more #409
Comments
Hi, it's me again (yes...)I'm still improving and refining the localization and I found another megaton of things that can be improved/fixed (this issue thread is going to be very long, shame at me) I think at the end we'll need to have a whole "to-do list" because there's so much things that it would be better to follow what is addressed/fixed or not.
I. MOAR™ localization issues I noticed
II. Other missing localization abilities
III. Other things
IV. Unrelated stuff that doesn't really worth opening a new bug report
That's all for now.If I found more things i will put them on a new reply, and then a recap would be made because that list starts to get very long haha! |
Repair element type here will not be localized because it comes from the game data itself. To avoid debugging confusion later, we probably not gonna change the behavior.
This one is separate issue, please make another ticket to avoid the issue being buried |
OK I uploaded the file, I think the rest of the procedure is on your side.
For the other issues like the reduce button i'll create the issue Also for the Byte unit thing, you say that it comes from the Windows SDK. It's somewhat weird a general SDK like this one cannot provide localized strings. But here again I tagged it as "optional" from the beginning because I was already aware a such weird thing can probably happen, so I'll not go mad if this isn't possible, it's just my perfectionist side (sorry). Last thing: I give my permission if you want to clear out entries that won't be addressed/fixed from the list, in order to keep it understandable among the things that will be. |
For French localization, I'll let @Cryotechnic verify and review all the strings on Transifex |
Hi @Kiki79250CoC. We have done some adjustment regarding to some localization and overflowed text in the latest commit. Artifact to test: As the progress goes on, some implementation might cannot be done due to some backward compatibility with other languages a bit tricky to get implemented.
For this, we have added a new entry to the localization called:
Also, the entry is now available on Transifex to get translated. |
Hi!
As I keep an eye on the issue, I was already testing it and noticing the changes when you posted your reply! I can already notice some great improvements, which is fine for the usability in general, which is (ngl) one of the main objectives of this issue report.
As I also have some projects on my side, I totally understand that, and we can agree on one thing: localization in general is always a huge pain in software development. That's probably why I abandoned all efforts of making my projets completely localized apart from just having English and my native language (French). The first one because it's universal, and the latter because why not, and as French is somewhat close to English, it requires little to no language-specific adaptations.
Thanks for this addition. After bagusnl's message, I was more in a mindset of "this idea is definitely scrapped", but to my surprise, you did it, and I thank you for that sweet attention to details I wasn't really expected to see coming anymore.
For the Transifex case, I will put the new strings on the board, and will wait for Cryo to approve the 350 other updated strings I've done on that revision. In the meantime, I'll continue to tweak strings and update the json file in my previous comment for anyone who wants to test out how the revised localization is supposed to look like when used in the software. The last revision includes the additions you've done in the commit and some little tweaking for better readability (and to satisfy my perfectionist "ThisSoftwareShouldHaveProfessionalLikeLocalization"-type impulses lol). ~~ |
Heyo, just letting you know that your file was uploaded and I'll be reviewing the translations hopefully tomorrow. Assuming everything goes well, the next time Transifex syncs, your strings will be included as part of that process. I'll update this post whenever this is done, though the review process may take a bit of time because of IRL responsibilities. Thanks again for contributing and helping to make Collapse accessible to a broader audience! |
Oh, that's nothing. Really. Btw @Cryotechnic, I performed a final checkup of the file to fix last quirks and to replace standard spaces with non-breaking spaces for punctuation signs and a new sync will be needed before reviewing the strings. This is the last "big" update for that file i'll perform outside of Transifex, so you can consider the last revision (from 3/11 9:37PM) as "gold", subsequent edits will be done directly on Transifex. If you have some questions during the reviewing towards some strings changes and textual choices I made, feel free to ask them here, I will answer them. |
@Kiki79250CoC OK, hopefully all the approved strings today will match what you have sent me. I've downloaded the file in your previous reply and reviewed them on Transifex. You'll be able to check 3748429 to see the changes, which will hopefully ship in the next minor release. Sorry for taking so long to approve the strings, IRL stuff keeps popping up. |
I quickly checked the commit, and everything seems to be present (including the fix for the "forgotten one").
No problem, everyone have their priorities. The final step is fully on your side, to fix the last quirks that remains to do in the list, and finally close this issue. Take your time, the amount of work you allow to Collapse is huge and should be rewarded by the strongest respect. ~~ Collapse using the finalized localization, and the |
Next version is scheduled as of annpuncement in Discord, somewhere after HSR 2.1 is live |
Hi, it's me againI found one more quirk that deserve a quick look for a potential fix that still have something to do with localization. Tested artifact: From Commit
Also @Cryotechnic, when you will approve the strings I will add once #434 will be merged (those are already translated and ready to be added into Transifex once available), I did some tweaks to fix some typos & reformulate some strings. All of them are in the suggestions (don't worry, there's not 300 edits so it should be fine). |
about this, im not sure if it is MS or NotifyIcon (Tray Icon dependency) issue, but I'd have to remove some of the string, probably both the version and the branch indicator to make sure all language can fit on that |
After searching on MS documentation, it seems to be an arbitrary limitation |
So, I want to report all things I found during the 3 days I spent to entirely revising the french localization.
During this time I found several issues/quirks/bugs
1. Weird things I found
2. Localization issues noticed
2.1. Strings that are too long to fit
b1-CLbug.mp4
2.2. Missing ability to localize some strings
And some optional things that are not important but that can be taken care about
The "Byte" (B) unit can technically be localized (for example "octet" (o) in French and Romanian).
Localize file types text on open/save dialogs
Localize official community links
3. Suggestions
Also, I'm wondering how we can deal with the updated localization.
I think I'll probably need to submit all modified strings to Transifex as I read that it's not that simple to update a bunch of lines from one shot.
In all case, I put the file here if someone want's to see what the localization looks before being put in a future update :
fr_FR.json
That's it for me.
The text was updated successfully, but these errors were encountered: