Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make caching optional #260

Merged
merged 2 commits into from
Apr 1, 2021
Merged

fix: make caching optional #260

merged 2 commits into from
Apr 1, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Apr 1, 2021

The changes introduced by #247 are a bit unstable. This PR makes caching optional, and disables it by default.

@redeboer redeboer added the 🐛 Bug Something isn't working label Apr 1, 2021
@redeboer redeboer self-assigned this Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #260 (6338d2c) into master (2c68eae) will decrease coverage by 0.92%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   79.94%   79.01%   -0.93%     
==========================================
  Files          13       13              
  Lines         743      753      +10     
  Branches      124      126       +2     
==========================================
+ Hits          594      595       +1     
- Misses        111      119       +8     
- Partials       38       39       +1     
Flag Coverage Δ
unittests 79.01% <40.00%> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/estimator.py 67.27% <40.00%> (-12.73%) ⬇️

@redeboer redeboer added this to the Release 0.2.2 milestone Apr 1, 2021
@redeboer redeboer merged commit f76663e into master Apr 1, 2021
@redeboer redeboer deleted the optional-caching branch April 1, 2021 11:25
@redeboer redeboer modified the milestones: 0.2.4, 0.2.2 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant