Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible replacement for GoPacket #5

Open
bediger4000 opened this issue Feb 12, 2020 · 1 comment
Open

Possible replacement for GoPacket #5

bediger4000 opened this issue Feb 12, 2020 · 1 comment

Comments

@bediger4000
Copy link

This probably isn't the best way to throw out an idea, but here we go...

Ravel uses Google's GoPacket packge (tgithub.com/google/gopacket) to collect stats about SYN, SYN+ACK, etc packets. If gopacket become a performance drag, it might be possible to get a performance boots from pfring

https://pkg.go.dev/github.com/google/gopacket/pfring?tab=doc

@abgordon
Copy link
Collaborator

abgordon commented Feb 12, 2020

Thanks for submitting and good to hear from you! I opened an issue that I see as a prerequisite for someone outside of the organization working on this (or anything): #6

Interesting idea, gopacket has not been recognized as a performance bottleneck but we haven't done any strict benchmarking. The Hyperloglog lib needs to be removed (#13), around 500k-750k PPS load it causes shared-map panics, addition of mutex slows it to the point of not reporting prometheus metrics.

Flow statistics produced by that are deemed low-value so we are removing that instead of further refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants