Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playlist.tagIndexes(forMediaSequence:) is not working properly. #21

Closed
dcoufal opened this issue Jun 20, 2018 · 1 comment
Closed

playlist.tagIndexes(forMediaSequence:) is not working properly. #21

dcoufal opened this issue Jun 20, 2018 · 1 comment
Assignees

Comments

@dcoufal
Copy link
Contributor

dcoufal commented Jun 20, 2018

Parse this variant:

#EXTM3U
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:3
#EXT-X-VERSION:3
#EXTINF:2.96130,
fileSequence0.ts
#EXTINF:2.96130,
fileSequence1.ts
#EXTINF:2.96129,
fileSequence2.ts
#EXTINF:2.96129,
fileSequence3.ts
#EXTINF:2.96130,
fileSequence4.ts
#EXTINF:2.96130,
fileSequence5.ts
#EXTINF:2.96129,
fileSequence6.ts
#EXTINF:2.96129,
fileSequence7.ts
#EXTINF:2.96130,
fileSequence8.ts
#EXTINF:2.96130,
fileSequence9.ts
#EXTINF:2.96129,
fileSequence10.ts

Call playlist.tagIndexes(forMediaSequence: 0)

Expected Behavior

I would expect to get a range back (namely 4...5, I think, but there should be a range as that media sequence exists)

Observed Behavior

You get nil back.

Note that if you call playlist.segmentGroup(forMediaSequence: 0) you do get the correct structure back and that structure has the correct range, so this problem is likely trivial to fix.

Reproduction Steps

(steps are above)

Observed on device(s):

  • iPhone X Simulator

Observed on OS Version(s):

  • iOS 11.4

Notes:

Please add a unit test for this as part of the fix.

@dcoufal
Copy link
Contributor Author

dcoufal commented Jun 28, 2018

Fixed and merged.

@dcoufal dcoufal closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants