You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might be overly restrictive, especially since (for example) IOException is not a subclass of RuntimeException. Is there a reason SiriusResult can't just wrap Exception? I get that RuntimeException is the superclass of unchecked exceptions, but it's not obvious to me if or why that would be relevant.
The text was updated successfully, but these errors were encountered:
Well, since there are no throws declarations on the RequestHandler methods, it's not possible for checked exceptions to be thrown there. But there's no particular reason it couldn't be an Exception instead of a RuntimeException in a SiriusResult. I suspect if we clean up the RequestHandler interface as a result of dealing with #6 that a solution to this issue will fall out as well.
Good point. Yes, the Sirius library can't catch those exceptions, but I might reasonably want to catch them myself in my handlePut function and wrap them in the SiriusResult (or whatever it ends up being).
This might be overly restrictive, especially since (for example) IOException is not a subclass of RuntimeException. Is there a reason SiriusResult can't just wrap Exception? I get that RuntimeException is the superclass of unchecked exceptions, but it's not obvious to me if or why that would be relevant.
The text was updated successfully, but these errors were encountered: