-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] TouchEffect #86
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@naweed we don't have a date to share |
@pictos can I confirm if/when this is done it will be a Behaviour, not an effect, right? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Here is the most important point, in the experience of XF, that the ListView and CollectionView gestures did not allow to process all the other gestures. And of course multiple gesture handlers are also needed |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@pictos @brminnick is there any design decision about using behavior or effect? Maybe we can make decision about it and I can start implementation? |
@KSemenenko this is in WIP mode, I'm working this. Thanks |
@criss02-cs MauiCompat target framework is net6.0. |
Checking the code for the Touch Behavior in the touch-effect branch we noticed that the implementation is missing handling a move event and exposing it to the users. |
At this point this proposal does not specify the move events. It's a terrific addition no doubt to have this to maintain parity with Xamarin CommunityToolkit. I think it is best to get this version out as soon as we can and then we can put in the move events shortly after. If it is critical for you in the meantime you could port the XCT move across in a PR so we can get it in as soon as possible. |
approximately when will we have the opportunity to have this functionality? |
I do believe that some functionality is better than none. |
The The MauiCompat library doesn't seem to work in any of my net7 / 8 maui apps. I can see there is a planned release for this effect in net8 & can see the I'm not putting this on NuGet, for anyone wanting to use it my suggestion is build it locally and either host it in a private nuget feed (such as azure devops) or reference locally. Really looking forward to this being released properly! |
@kphillpotts is there any rough estimation or planning when to expect this feature coming in? |
I was watching .net conf and see this video on maui They talk about point gestures and that they can be used to detect things like long press, also the docs https://learn.microsoft.com/en-us/dotnet/maui/fundamentals/gestures/pointer?view=net-maui-8.0&tabs=windows I didn't have the time to check this out, have anyone worked with these? |
I don't think thing the Pointer gesture is enough, it doesn't have event that will be fired when user just hold on and didn't move their finger. So how can we detect something like that? |
@unamed000 It could work on all platforms with just one implementation. |
@fredericoregateiro Actually I use the following package for TouchEffects unless its implemented in the CommunityToolkit. API is compatible to the old XF implementation and works fine for Android and iOS. Quite fresh nuget package but quality is ok. https://www.nuget.org/packages/TouchEffect.Maui |
This looks familiar... too familiar. Not that I put my maui port up for fame and glory, but when this library is clearly just my repo slightly reworded, with no credit or the crucial context that this library is a stopgap for the MCT feature, feels a little wild west... Coincidentally I just updated my port to NET 8 & Fixed an iOS bug to do with input transparency (something I did after this repo was copied). We now have loads of wish.com maui touch effects floating around, we are in dire need of the official thing. Is there any word on the state of the current feature? I am super happy to jump in and help get this feature over the line so we can end the compat library wars! |
@Axemasta 😔 yeah this is not great. Might be good to maybe get this out of the way, awesome you're willing to help out. Did you join our Discord server by any chance? That might be good to get some coordination going? |
@Axemasta First of all I want to apologize, you are right my package is entirely your code and I don't have any mention to you... I don't used your Nuget because it's deprecated and you have mentioned that you have no intention to maintain other platforms, so I started my version to solve this for the app migrations that I'm doing... I want to talk to you in order to resolve this, maybe removing my package and contributing to your original code.. or anything that you have in mind... Sorry again |
If u just want pressed, released and clicked events, you could try my control out - https://github.com/IeuanWalker/Maui.StateButton |
@felipebaltazar any plans for a PR to @Axemasta 's project for Windows support? Do you have in your repo any plans for a Windows branch? |
Any news about this feature coming to .NET MAUI Community Toolkit? I need it for my application. |
Still being worked on, stay tuned! |
This comment has been minimized.
This comment has been minimized.
Your going to have issues with this implementation if the clickable element in within a scroll view and the user scrolls on the clickable element |
@jfversluis is there a short-term alternative for .NET 8/MAUI? |
No I think you will just have to wait and watch this PR #1673 |
Or of course implement it yourself. Any plugin or project is someone else writing code you could've written yourself. Otherwise, done when it's done 😄 and we hear you, we see a lot of people want this. So we're working on it. |
If you scroll up you'll see my links, I ported the XCT implementation to Maui and have it available as a "build, fork or drop into your projects yourself & use at your own risk" type deal. I'm currently using that library in my own apps and its been rock solid so far. Currently working on the MCT PR to get this feature into the toolkit for 2 reasons. 1 its not my project, I just did a port and want the credit to go to the toolkit guys & Andrei who originally wrote it + donated to xct. 2 I dont want sole maintenance responsibility, it would be better when a team of people can manage it that way we know its super solid |
Noted sir. I have tested it in a sample .NET 8/MAUI project and it seems to do what I was doing in the Xamarin CT, so thank you. |
@Axemasta we really appreciate this effort that you are putting in and I'm sure everyone would agree that you certainly deserve the credit for it! |
All done, released as part of v8.0.0 |
TouchEffect
Summary
Adds additional touch events to any VisualElement
Detailed Design
TouchEffect.shared.cs
Usage Syntax
C# Usage
The text was updated successfully, but these errors were encountered: