Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for draw functions #312

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Tests for draw functions #312

merged 3 commits into from
Mar 29, 2023

Conversation

maximelucas
Copy link
Collaborator

@maximelucas maximelucas commented Mar 28, 2023

  • tests for draw functions
  • added defaults param values to all draw functions
  • tests for clustering

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.62 🎉

Comparison is base (7cc3b6b) 84.32% compared to head (54556e6) 89.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   84.32%   89.94%   +5.62%     
==========================================
  Files          35       35              
  Lines        2756     2796      +40     
==========================================
+ Hits         2324     2515     +191     
+ Misses        432      281     -151     
Impacted Files Coverage Δ
xgi/drawing/draw.py 69.54% <100.00%> (+45.52%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@nwlandry nwlandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! A few things:

  • I would be in favor of keeping it as net instead of H in nodestats, but if you feel strongly, make sure that it's consistent.
  • If you could add a test to check that the nodes, lines, edges are plotted on the right layer, that would be awesome, but frankly what you have is a huge improvement, so no sweat if not.
  • I think that someone mentioned that the clustering coefficient is not between 0 and 1. Can you add this as an issue?
  • I like adding the optional arguments to the draw nodes/edges functions.

Overall looks great and I think I'm good with merging this!

tests/drawing/test_draw.py Show resolved Hide resolved
xgi/drawing/draw.py Show resolved Hide resolved
@maximelucas
Copy link
Collaborator Author

All done. I had already raised issue #309 about the clustering coefficient :) We'll need to test it once the right answer is decided.

@maximelucas maximelucas merged commit 472c92b into main Mar 29, 2023
@maximelucas maximelucas deleted the tests branch March 29, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants