Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zlib to dev-shell to fix cargo nightly #2331

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Nov 16, 2022

Issue

Can't run things with cargo +nightly (i.e SKIP_WASM_BUILD=1 bacon clippy -- --all --tests)

Additional Changes

Added zlib to dev-shell. Fix inspired by this

Concerns: bacon ran with SKIP_WASM_BUILD=1 bacon clippy -- --all --tests is reporting many things on main as errors with this fix, which does not match with CI (20 errors, 1918 warnings 😵‍💫 )

Note, this is probably a naive fix - feel free to correct/roast

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-staging ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 6:59PM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 6:59PM (UTC)

@PoisonPhang PoisonPhang marked this pull request as ready for review November 16, 2022 18:36
@PoisonPhang PoisonPhang requested a review from a team as a code owner November 16, 2022 18:36
@PoisonPhang PoisonPhang requested a review from cor November 16, 2022 18:36
@github-actions
Copy link

github-actions bot commented Nov 16, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/8ea8a6e905402be1aa4322bf6eacd4aaff450e5d#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-staging November 16, 2022 18:38 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 16, 2022 18:39 Inactive
Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Regarding the difference in error count: we can fix that in a later PR, actually good that we're able to run bacon now

@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 16, 2022 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-staging November 16, 2022 18:59 Inactive
mergify bot added a commit that referenced this pull request Nov 16, 2022
@mergify mergify bot merged commit 229e3c3 into main Nov 16, 2022
@mergify mergify bot deleted the connor/nix-cargo-nightly branch November 16, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants