Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU-3vz1bh3] update assets RPC on Picasso #2392

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

andresmechali
Copy link
Contributor

@andresmechali andresmechali requested a review from a team November 22, 2022 16:58
@itsbobbyzz
Copy link

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/b30e47d0f626a3b638465bc5f6efd872f57769ba --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/b30e47d0f626a3b638465bc5f6efd872f57769ba#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/b30e47d0f626a3b638465bc5f6efd872f57769ba#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/b30e47d0f626a3b638465bc5f6efd872f57769ba#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/b30e47d0f626a3b638465bc5f6efd872f57769ba#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-nightly ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 4:58PM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 4:58PM (UTC)

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 22, 2022 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 22, 2022 19:51 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 16:53 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 30, 2022 16:58 Inactive
mergify bot added a commit that referenced this pull request Dec 2, 2022
@vimukthi-git
Copy link
Contributor

@andresmechali Did you get the chance to dev-test that this works?

@andresmechali
Copy link
Contributor Author

@andresmechali Did you get the chance to dev-test that this works?

@vimukthi-git I ran the chain locally (nix run "#devnet-picasso") and ran the integration tests for this RPC

Copy link
Contributor

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresmechali
Copy link
Contributor Author

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Dec 5, 2022
@mergify mergify bot merged commit 442670a into main Dec 5, 2022
@mergify mergify bot deleted the andres/assets-rpc-on-picasso branch December 5, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants