Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fixes on XCVM SPEC #2402

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Tiny fixes on XCVM SPEC #2402

merged 1 commit into from
Nov 23, 2022

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Nov 23, 2022

  • Bindings should be a vector.
  • Binding indices must be sorted and unique.
  • RelayerRegister should be <Account> instead of <u32> since it points to a relayer.

Issue

Additional Changes

Checklist

  • Updated the rust/typescript docs.
  • Updated the docs/.

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz requested a review from a team November 23, 2022 11:22
@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-nightly ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 11:40AM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 11:40AM (UTC)

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/e522f736efbeb342cac73a223780356d2f27d784 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/e522f736efbeb342cac73a223780356d2f27d784#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/e522f736efbeb342cac73a223780356d2f27d784#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/e522f736efbeb342cac73a223780356d2f27d784#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/e522f736efbeb342cac73a223780356d2f27d784#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 23, 2022 11:25 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 23, 2022 11:40 Inactive
@kkx kkx self-requested a review November 23, 2022 12:18
mergify bot added a commit that referenced this pull request Nov 23, 2022
@mergify mergify bot merged commit 04a1374 into main Nov 23, 2022
@mergify mergify bot deleted the fix/SPEC.md branch November 23, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants