-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Picasso] - Release 1 - Added isPalletSupported function #2411
Conversation
…o avoid runtime errors
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
Visit the preview URL for this PR (updated for commit 7641669): https://picasso-f0d16--pr2411-picasso-pallet-check-4kvk10kj.web.app (expires Thu, 01 Dec 2022 09:46:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d4e030ec330173845b1768cd217beee9791d20f1 |
Visit the preview URL for this PR (updated for commit 7641669): https://pablo-afa5d--pr2411-picasso-pallet-check-83y3c2w4.web.app (expires Thu, 01 Dec 2022 09:47:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - could help a little for a reviewer if the description had a little more detail 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Absolutely, So I was checking the Prod release and noticed that some of the pallets we use in frontend is not available in mainnet. That was the main reason behind adding this PR and Utility function/component to prevent crashing the app if something is missing in the connected chain. This makes the UI more versatile to connect to different environments. |
This PR checks for existence of certain pallets before calling storage/extrinsic functions.