Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picasso] - Release 1 - Added isPalletSupported function #2411

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

easteregg
Copy link
Contributor

This PR checks for existence of certain pallets before calling storage/extrinsic functions.

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-nightly ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 9:37AM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 9:37AM (UTC)

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/76416692639cd617a75668b5edcc5b08645f3dcb#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 24, 2022 09:32 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 24, 2022 09:37 Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 7641669):

https://picasso-f0d16--pr2411-picasso-pallet-check-4kvk10kj.web.app

(expires Thu, 01 Dec 2022 09:46:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d4e030ec330173845b1768cd217beee9791d20f1

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 7641669):

https://pablo-afa5d--pr2411-picasso-pallet-check-83y3c2w4.web.app

(expires Thu, 01 Dec 2022 09:47:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3

Copy link
Contributor

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - could help a little for a reviewer if the description had a little more detail 👍

Copy link
Contributor

@andresmechali andresmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easteregg
Copy link
Contributor Author

lgtm - could help a little for a reviewer if the description had a little more detail 👍

Absolutely,

So I was checking the Prod release and noticed that some of the pallets we use in frontend is not available in mainnet.

That was the main reason behind adding this PR and Utility function/component to prevent crashing the app if something is missing in the connected chain.

This makes the UI more versatile to connect to different environments.

mergify bot added a commit that referenced this pull request Nov 24, 2022
@mergify mergify bot merged commit 47e0678 into main Nov 24, 2022
@mergify mergify bot deleted the picasso_pallet_check branch November 24, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants