Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc integration and test #2431

Merged
merged 17 commits into from
Dec 11, 2022
Merged

ibc integration and test #2431

merged 17 commits into from
Dec 11, 2022

Conversation

kkx
Copy link
Contributor

@kkx kkx commented Nov 24, 2022

Issue

https://app.clickup.com/t/3qvfj7v

Additional Changes

  • refactor evm SDK and create a shared lib to be used by both the interpreter and ibcBridge
  • enabled both hardhat tests and forge tests
  • we can leave lib/forge-std and src/ibc out of the review scope since they are imported and in the future will be installed and imported directly.

Checklist

  • Updated the rust/typescript docs.
  • Updated the docs/.

@kkx kkx requested a review from a team as a code owner November 24, 2022 22:43
@kkx kkx requested a review from a team November 24, 2022 22:43
@kkx kkx requested a review from a team as a code owner November 24, 2022 22:43
@kkx kkx requested a review from a team November 24, 2022 22:43
@kkx kkx requested a review from a team as a code owner November 24, 2022 22:43
@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 11, 2022 at 0:11AM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 11, 2022 at 0:11AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/c6607a6389eaaa98df009c1986143e509b810127 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/c6607a6389eaaa98df009c1986143e509b810127#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/c6607a6389eaaa98df009c1986143e509b810127#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/c6607a6389eaaa98df009c1986143e509b810127#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/c6607a6389eaaa98df009c1986143e509b810127#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 24, 2022 22:49 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 24, 2022 23:04 Inactive
@kkx kkx force-pushed the feat/evm_ibc_integration branch 3 times, most recently from a2d45c1 to b6e4a70 Compare November 25, 2022 11:39
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 25, 2022 12:00 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 25, 2022 12:10 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 25, 2022 12:16 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 25, 2022 12:25 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 28, 2022 18:59 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 28, 2022 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 28, 2022 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 28, 2022 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 29, 2022 00:15 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 29, 2022 00:20 Inactive
@kkx kkx requested a review from aeryz November 30, 2022 12:35
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 12:40 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 30, 2022 12:45 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 1, 2022 09:48 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 1, 2022 09:53 Inactive
@kkx kkx requested a review from bostercf December 1, 2022 11:55
@itsbobbyzz
Copy link

Copy link
Contributor

@hussein-aitlahcen hussein-aitlahcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have this one merged and refine with the spec right after the Rust side is fully stable :)

@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 5, 2022 08:53 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 5, 2022 08:58 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 7, 2022 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 9, 2022 14:19 Inactive
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Visit the preview URL for this PR (updated for commit fc1356c):

https://picasso-f0d16--pr2431-feat-evm-ibc-integra-6b4mbcvy.web.app

(expires Fri, 16 Dec 2022 14:25:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d4e030ec330173845b1768cd217beee9791d20f1

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Visit the preview URL for this PR (updated for commit fc1356c):

https://pablo-afa5d--pr2431-feat-evm-ibc-integra-9658dic8.web.app

(expires Fri, 16 Dec 2022 14:25:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3

mergify bot added a commit that referenced this pull request Dec 11, 2022
@mergify mergify bot merged commit a10c72e into main Dec 11, 2022
@mergify mergify bot deleted the feat/evm_ibc_integration branch December 11, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants