Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#done removed old democracy #2453

Merged
merged 2 commits into from
Dec 8, 2022
Merged

#done removed old democracy #2453

merged 2 commits into from
Dec 8, 2022

Conversation

dzmitry-lahoda
Copy link
Contributor

Signed-off-by: Dzmitry Lahoda dzmitry@lahoda.pro

Issue

no used and likely will not be used and obsolete copy paste

@dzmitry-lahoda dzmitry-lahoda requested a review from a team as a code owner November 26, 2022 17:23
@dzmitry-lahoda dzmitry-lahoda requested review from a team November 26, 2022 17:23
@dzmitry-lahoda dzmitry-lahoda requested a review from a team as a code owner November 26, 2022 17:23
@vercel
Copy link

vercel bot commented Nov 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 8, 2022 at 10:32AM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 8, 2022 at 10:32AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 26, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/83bed3f967f5e41de5b38f31faeca8505efb0e87 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/83bed3f967f5e41de5b38f31faeca8505efb0e87#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/83bed3f967f5e41de5b38f31faeca8505efb0e87#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/83bed3f967f5e41de5b38f31faeca8505efb0e87#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/83bed3f967f5e41de5b38f31faeca8505efb0e87#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 26, 2022 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 26, 2022 17:38 Inactive
@andyjsbell
Copy link
Contributor

Thanks @dzmitry-lahoda - do we have a task linked to this?

@dzmitry-lahoda dzmitry-lahoda changed the title removed old democracy #done removed old democracy Nov 30, 2022
@dzmitry-lahoda
Copy link
Contributor Author

dzmitry-lahoda commented Nov 30, 2022

@andyjsbell this was an exclusive case where it can be done under one hour :) really it took 15 minutes (ok - with rebase and review explanations 15+ more minutes). it was discussed 3 month ago afaik to remove it. so it was not clear before that if Gov v2 will support multi Origin (it appeared yes) and easy to make it multi currency (it seems yes) - so deleting is easy.

@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 30, 2022 09:51 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 09:59 Inactive
@andyjsbell
Copy link
Contributor

@dzmitry-lahoda No problem. Sounds like it would have take longer to create the task than do it.

Copy link
Contributor

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyjsbell
Copy link
Contributor

@dzmitry-lahoda was the reason why this was closed?

@dzmitry-lahoda
Copy link
Contributor Author

oh, sorry. was mistake.

@dzmitry-lahoda dzmitry-lahoda reopened this Dec 6, 2022
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
mergify bot added a commit that referenced this pull request Dec 8, 2022
@mergify mergify bot merged commit ac0c5e8 into main Dec 8, 2022
@mergify mergify bot deleted the dz/cleanup/democracy branch December 8, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants