Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests: Re- enabling KSM XCM Tests & minor doc, clean code fixes #2454

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

Dominique-Roth
Copy link
Contributor

@Dominique-Roth Dominique-Roth commented Nov 28, 2022

Issue

Would be great if i could create a ClickUp ticket, right?
XCM Integration Tests for Kusama test transfers were disabled last week due to an issue, that couldn't be reproduced.
Therefore re- enabling them here & hoping for the best.

Additional Changes

The code comments were partially wrong / misleading, and there was a double before block. Which by current integration test standards we're trying to avoid.

Checklist

- [ ] Updated the rust/typescript docs.
- [ ] Updated the docs/.

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-nightly ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 7:35AM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 7:35AM (UTC)

@Dominique-Roth Dominique-Roth marked this pull request as ready for review November 28, 2022 07:29
@Dominique-Roth Dominique-Roth requested a review from a team as a code owner November 28, 2022 07:29
@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/c288eabdfb8c9c74a6230e020e55e20bab8cd26a --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/c288eabdfb8c9c74a6230e020e55e20bab8cd26a#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/c288eabdfb8c9c74a6230e020e55e20bab8cd26a#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/c288eabdfb8c9c74a6230e020e55e20bab8cd26a#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/c288eabdfb8c9c74a6230e020e55e20bab8cd26a#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 28, 2022 07:30 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 28, 2022 07:35 Inactive
Copy link

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged

mergify bot added a commit that referenced this pull request Nov 28, 2022
@mergify mergify bot merged commit bf5cafd into main Nov 28, 2022
@mergify mergify bot deleted the integration-tests/xcmp-fix branch November 28, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants