Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3u4b2eq #CU-3u4b2ad zombienet builder running simplest dali devnet #2496

Merged
merged 20 commits into from
Dec 12, 2022

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Nov 30, 2022

Issue

  • nix run .#devnet-dali runs zombienet, CI tests works well (well on infra level, logically they incorrect)

https://app.clickup.com/t/3u4b2ad

@dzmitry-lahoda dzmitry-lahoda requested review from a team as code owners November 30, 2022 14:21
@dzmitry-lahoda dzmitry-lahoda requested review from a team November 30, 2022 14:21
@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pablo-nightly ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 9:39AM (UTC)
picasso-nightly ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 9:39AM (UTC)

@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft November 30, 2022 14:21
@dzmitry-lahoda dzmitry-lahoda changed the base branch from main to dz/zombienet/bin November 30, 2022 14:21
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/52b2937a5f4508457c24b61d5ec0326e3335dd92 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/52b2937a5f4508457c24b61d5ec0326e3335dd92#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/52b2937a5f4508457c24b61d5ec0326e3335dd92#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/52b2937a5f4508457c24b61d5ec0326e3335dd92#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/52b2937a5f4508457c24b61d5ec0326e3335dd92#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 30, 2022 14:43 Inactive
@dzmitry-lahoda dzmitry-lahoda changed the title #draft #wip Dz/zombienet/template #draft #wip #CU-3u4b2ad zombienet builder running simples dali devnet Nov 30, 2022
@itsbobbyzz
Copy link

@dzmitry-lahoda dzmitry-lahoda changed the title #draft #wip #CU-3u4b2ad zombienet builder running simples dali devnet #draft #wip #CU-3u4b2ad zombienet builder running simplest dali devnet Nov 30, 2022
Base automatically changed from dz/zombienet/bin to main November 30, 2022 17:06
@vercel vercel bot temporarily deployed to Preview – pablo-nightly November 30, 2022 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly November 30, 2022 17:46 Inactive
@andyjsbell
Copy link
Contributor

@dzmitry-lahoda could we get a description on this please?

@dzmitry-lahoda
Copy link
Contributor Author

@andyjsbell added

@andyjsbell
Copy link
Contributor

Does it need to stay in draft ?

@dzmitry-lahoda
Copy link
Contributor Author

dzmitry-lahoda commented Dec 1, 2022

Does it need to stay in draft ?

@andyjsbell yeah, I am working on this. so it is draft. but any comments are welcome.

@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 5, 2022 12:21 Inactive
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 724b839):

https://picasso-f0d16--pr2496-dz-zombienet-templat-0phwj1xw.web.app

(expires Mon, 12 Dec 2022 12:43:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d4e030ec330173845b1768cd217beee9791d20f1

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 724b839):

https://pablo-afa5d--pr2496-dz-zombienet-templat-ny5sbxyo.web.app

(expires Mon, 12 Dec 2022 12:43:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3

@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 5, 2022 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 5, 2022 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 5, 2022 16:04 Inactive
@dzmitry-lahoda
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2022

refresh

✅ Pull request refreshed

@dzmitry-lahoda
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

update

✅ Branch has been successfully updated

@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 9, 2022 09:33 Inactive
@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 9, 2022 09:39 Inactive
mergify bot added a commit that referenced this pull request Dec 9, 2022
@dzmitry-lahoda
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

refresh

✅ Pull request refreshed

@dzmitry-lahoda
Copy link
Contributor Author

@Dom-Roth @andresmechali may you help with this

  53 passing (33m)
  3 pending
  1 failing

  1) [SHORT] Vesting Pallet Tests
       #1.4  Multiple vested transfer beneficiaries (#1.1, #1.2, #1.3) can claim simultaneously.:

      AssertionError: expected '6000000000000' to equal '7000000000000'      
      actual expected
      
      60000000000007000000000000
      
      at vestedScheduleClaimVerifier.verifyVestedScheduleClaim (/home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/testHelper.ts:193:41)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at /home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/vestingTests.ts:481:9
      at Context.<anonymous> (/home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/vestingTests.ts:463:5)

I can create CU task if that fix.

Tests are brittle. They rely on initial balance == to some specific value. They should not. They should use any balance >= X and later check not absolute values but decrease and increces.

@dzmitry-lahoda
Copy link
Contributor Author

I can ignore the test if that is OK too.

@dzmitry-lahoda
Copy link
Contributor Author

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Dec 12, 2022
@mergify mergify bot merged commit 60ff087 into main Dec 12, 2022
@mergify mergify bot deleted the dz/zombienet/template branch December 12, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants