Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RuntimeTrait DX #2625

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Improve RuntimeTrait DX #2625

merged 3 commits into from
Dec 10, 2022

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Dec 8, 2022

Improves the DX of RuntimeTrait. The where bounds no longer need to be duplicated at the use site when RuntimeTrait is used as a constraint.

(the branch was supposed to be called ben/runtime-trait-improvements, not reward, it's been a long day)

@benluelo benluelo requested review from a team December 8, 2022 20:43
@benluelo benluelo requested review from a team as code owners December 8, 2022 20:43
@vercel
Copy link

vercel bot commented Dec 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 9, 2022 at 2:31PM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 9, 2022 at 2:31PM (UTC)

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/23da39d46f00b54778f2bd6a5abb47bca8027eb5 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/23da39d46f00b54778f2bd6a5abb47bca8027eb5#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/23da39d46f00b54778f2bd6a5abb47bca8027eb5#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/23da39d46f00b54778f2bd6a5abb47bca8027eb5#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/23da39d46f00b54778f2bd6a5abb47bca8027eb5#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@benluelo benluelo force-pushed the ben/reward-trait-improvements branch from 6ec28b8 to 3180f8c Compare December 8, 2022 20:45
@benluelo benluelo removed request for a team December 8, 2022 20:53
@benluelo benluelo mentioned this pull request Dec 8, 2022
mergify bot added a commit that referenced this pull request Dec 8, 2022
@benluelo benluelo force-pushed the ben/reward-trait-improvements branch from 8848b91 to 23da39d Compare December 9, 2022 14:06
mergify bot added a commit that referenced this pull request Dec 9, 2022
@benluelo
Copy link
Contributor Author

benluelo commented Dec 9, 2022

mergify refresh

2 similar comments
@benluelo
Copy link
Contributor Author

mergify refresh

@benluelo
Copy link
Contributor Author

mergify refresh

mergify bot added a commit that referenced this pull request Dec 10, 2022
@mergify mergify bot merged commit 65cca17 into main Dec 10, 2022
@mergify mergify bot deleted the ben/reward-trait-improvements branch December 10, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants