Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent big non lfs files #2646

Merged
merged 5 commits into from
Dec 13, 2022
Merged

prevent big non lfs files #2646

merged 5 commits into from
Dec 13, 2022

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Dec 11, 2022

  • so that our nix channel continue work all instead growing too big
  • and git clone will work better too

Signed-off-by: Dzmitry Lahoda dzmitry@lahoda.pro

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@dzmitry-lahoda dzmitry-lahoda requested review from a team December 11, 2022 13:51
@vercel
Copy link

vercel bot commented Dec 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 11, 2022 at 2:37PM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 11, 2022 at 2:37PM (UTC)

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@github-actions
Copy link

github-actions bot commented Dec 11, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/5306af5548276d67d111719b11c5955f3812a693#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package

For more info on how to use Nix, check out our Nix docs

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@dzmitry-lahoda
Copy link
Contributor Author

@Dom-Roth @andresmechali

  [SHORT][LAUNCH] tx.xcmp Tests
2022-12-11 15:28:30        API/INIT: RPC methods not decorated: cosmwasm_instantiate, cosmwasm_query, lending_currentInterestRate, pablo_simulateAddLiquidity, pablo_simulateRemoveLiquidity
2022-12-11 15:28:30        API/INIT: dali/10003: Not decorating unknown runtime apis: 0x4fd044c5acf6fd0b/1, 0x9c53906fa888fe7c/1, 0x5c497be959ff24ab/1, 0xf60c4a6e7ca253cc/1, 0x33de0bdcf9563693/1, 0x42ac2ef5553b6436/1
    xcmPallet.reserveTransferAssets Success Test
      ✔ Can transfer asset(KSM) from relay chain(Kusama) to Picasso
    xTokens.transfer Success Test
      ✔ Can transfer asset(KSM) from Picasso to relay chain(Kusama).


  53 passing (33m)
  3 pending
  1 failing

  1) [SHORT] Vesting Pallet Tests
       #1.4  Multiple vested transfer beneficiaries (#1.1, #1.2, #1.3) can claim simultaneously.:

      AssertionError: expected '7000000000000' to equal '8000000000000'      
      actual expected
      
      70000000000008000000000000
      
      at vestedScheduleClaimVerifier.verifyVestedScheduleClaim (/home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/testHelper.ts:193:41)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at /home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/vestingTests.ts:481:9
      at Context.<anonymous> (/home/runner/work/composable/composable/code/integration-tests/runtime-tests/test/tests/vesting/ts/test/tests/vesting/vestingTests.ts:463:5)

can we just comment out this?

imho other way to fix - 1. ensure amount >= operation. 2. record amount. 3. act. 4. diff 5. assert diff is >= need within delta (see how i authored simulator test).

@dzmitry-lahoda
Copy link
Contributor Author

@Dom-Roth please take a look #2650

@dzmitry-lahoda
Copy link
Contributor Author

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Dec 13, 2022
mergify bot added a commit that referenced this pull request Dec 13, 2022
@mergify mergify bot merged commit 51e05fc into main Dec 13, 2022
@mergify mergify bot deleted the dz/ci/lfs branch December 13, 2022 02:41
mergify bot pushed a commit that referenced this pull request Dec 15, 2022
…diffed) (#2707)

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

## Issue

LFS was added and file extensions to LFS, but these file not migrated. 

After #2646 it appeared
that need #2694 and also
better to migrate (idea before was not to force migrate, but ensure all
new items in LFS). But seems migration is less noisy.

So this PR is result of running just one command to do migration
https://github.com/git-lfs/git-lfs/blob/main/docs/man/git-lfs-migrate.adoc?utm_source=gitlfs_site&utm_medium=doc_man_migrate_link&utm_campaign=gitlfs
. Nothing more.

Why? Because LFS has no history and may be avoided on some checkouts
which slows down monorepo degradation.

## Checklist

- @easteregg or other FE is ok for FE stuff
- @cor or @Martin-Kiss are ok for doc stuff
- @Dom-Roth 🥇 seems got `lfs detected` label violation first
#2630

- look at docasaurus after it released 
- look at UI

because most of files (only audit may be not) are from UI or docs

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants