-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent big non lfs files #2646
Conversation
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/5306af5548276d67d111719b11c5955f3812a693#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/5306af5548276d67d111719b11c5955f3812a693#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap For more info on how to use Nix, check out our Nix docs Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported. |
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@Dom-Roth @andresmechali
can we just comment out this? imho other way to fix - 1. ensure amount >= operation. 2. record amount. 3. act. 4. diff 5. assert diff is >= need within delta (see how i authored simulator test). |
@Dom-Roth please take a look #2650 |
@mergify refresh |
✅ Pull request refreshed |
…diffed) (#2707) Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro> ## Issue LFS was added and file extensions to LFS, but these file not migrated. After #2646 it appeared that need #2694 and also better to migrate (idea before was not to force migrate, but ensure all new items in LFS). But seems migration is less noisy. So this PR is result of running just one command to do migration https://github.com/git-lfs/git-lfs/blob/main/docs/man/git-lfs-migrate.adoc?utm_source=gitlfs_site&utm_medium=doc_man_migrate_link&utm_campaign=gitlfs . Nothing more. Why? Because LFS has no history and may be avoided on some checkouts which slows down monorepo degradation. ## Checklist - @easteregg or other FE is ok for FE stuff - @cor or @Martin-Kiss are ok for doc stuff - @Dom-Roth 🥇 seems got `lfs detected` label violation first #2630 - look at docasaurus after it released - look at UI because most of files (only audit may be not) are from UI or docs Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda dzmitry@lahoda.pro