Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering for rustSrc #2666

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

KaiserKarel
Copy link
Contributor

No description provided.

@KaiserKarel KaiserKarel requested a review from a team December 13, 2022 01:41
@KaiserKarel KaiserKarel requested a review from a team as a code owner December 13, 2022 01:41
@KaiserKarel KaiserKarel requested a review from a team December 13, 2022 01:41
@itsbobbyzz
Copy link

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 13, 2022 at 0:26AM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 13, 2022 at 0:26AM (UTC)

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@KaiserKarel KaiserKarel force-pushed the fix-src-files-for-runtime-and-node-derivations-(NX-29) branch from d1c2529 to bf66a0e Compare December 13, 2022 02:05
@KaiserKarel KaiserKarel force-pushed the fix-src-files-for-runtime-and-node-derivations-(NX-29) branch from bf66a0e to 725758d Compare December 13, 2022 02:10
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust may embeed anything. json for example. build.rs can co sume configs.

@KaiserKarel
Copy link
Contributor Author

rust may embeed anything. json for example. build.rs can co sume configs.

Then the build will fail, and we can include it in the filter?

@dzmitry-lahoda
Copy link
Contributor

yes. build will fail. so imho it is premature optimization.

@KaiserKarel
Copy link
Contributor Author

yes. build will fail. so imho it is premature optimization.

Let's see how much this speeds up CI once it passes checks, and then see if we want to merge. :)

I'm thinking if runs are +10 minutes faster, it is worth it.

mergify bot added a commit that referenced this pull request Dec 13, 2022
@KaiserKarel
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Dec 13, 2022
@mergify mergify bot merged commit 9b5f40e into main Dec 13, 2022
@mergify mergify bot deleted the fix-src-files-for-runtime-and-node-derivations-(NX-29) branch December 13, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants