-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering for rustSrc #2666
Add filtering for rustSrc #2666
Conversation
Task linked: NX-29 fix src files for runtime and node derivations |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/f1c8b453ef4bb14cfa552f6a02c897b8fcea8197#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
d1c2529
to
bf66a0e
Compare
bf66a0e
to
725758d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust may embeed anything. json for example. build.rs can co sume configs.
Then the build will fail, and we can include it in the filter? |
yes. build will fail. so imho it is premature optimization. |
Let's see how much this speeds up CI once it passes checks, and then see if we want to merge. :) I'm thinking if runs are +10 minutes faster, it is worth it. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
No description provided.