Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cosmwasm): use migrate from cosmwasm vm #2698

Merged
merged 3 commits into from
Dec 16, 2022
Merged

fix(cosmwasm): use migrate from cosmwasm vm #2698

merged 3 commits into from
Dec 16, 2022

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Dec 14, 2022

  • Fix migrate to check if the admin check is done properly before execution.
  • Make sure that gas is properly refund if the execution fails.

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz requested a review from a team as a code owner December 14, 2022 07:12
@itsbobbyzz
Copy link

Task linked: XCVM-257 Fix migrate entry point call

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 15, 2022 at 4:29PM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 15, 2022 at 4:29PM (UTC)

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/44a49d5247c12cabcf946a7250bc79e6372823d6 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/44a49d5247c12cabcf946a7250bc79e6372823d6#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/44a49d5247c12cabcf946a7250bc79e6372823d6#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/44a49d5247c12cabcf946a7250bc79e6372823d6#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/44a49d5247c12cabcf946a7250bc79e6372823d6#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

Signed-off-by: aeryz <abdullaheryz@protonmail.com>
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@mergify mergify bot merged commit fb96e39 into main Dec 16, 2022
@mergify mergify bot deleted the aeryz/XCVM-257 branch December 16, 2022 11:18
mergify bot added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants