Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan renderer doesn't work when Vulkan implementation has more than 4 queue families #195

Closed
pdaniell-nv opened this issue Apr 29, 2021 · 2 comments

Comments

@pdaniell-nv
Copy link

It appears this line of code in the Vulkan renderer will cause a stack corruption if the Vulkan implementation exposes more than 4 queue families:

VkDeviceQueueCreateInfo queue_create_infos[4] = {};

With the release of Vulkan video the latest NVIDIA beta drivers are now exposing 5 queue families - universal, transfer, compute, video decode, video encode:
https://developer.nvidia.com/vulkan-driver

This causes the queue_create_infos[4] variable to spill over to other variables in the stack and corrupt the create_info used for vkCreateDevice, which causes the Vulkan loader to crash.

A trivial fix would be to dynamically allocate queue_create_infos based on the queueFamiliesCount.

@manas-kulkarni
Copy link

Good catch. Will be fixed in next release

@wolfgangfengel
Copy link
Contributor

Can you confirm that it is resolved with release 1.48?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants