rm-wg feedback changes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NoExecute that prevents BestEffort and Burstable QoS class pods from | ||
| running on the node. BestEffort and Burstable QoS class pods are | ||
| evicted from the node. | ||
| 1. The CPU manager sets a `CPUPressure` node condition to `true` |
There was a problem hiding this comment.
state why this is preferred versus reserving some slack cpu for scavengers? i agree with this approach, but woudl like to explain that we dont think the complexity to support scavengers on nodes with this configuration is worth it.
sjenning
force-pushed
the
cpu-manager-proposal
branch
from
8be4f75
to
982b119
Compare
ConnorDoyle
pushed a commit
that referenced
this pull request
Aug 2, 2017
ConnorDoyle
pushed a commit
that referenced
this pull request
Aug 2, 2017
Wrong link to sig lead github page - Take #2
|
Sorry @sjenning if this should have been merged, totally missed it. Ping in PR if you make a new one against upstream and I will review ASAP. |
ConnorDoyle
pushed a commit
that referenced
this pull request
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @derekwaynecarr