perf(bn254): optimize affine pairing with doubleAndAdd #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In affine pairing (
MillerLoopFixedQ
), usedoubleAndAdd
to compute2P+Q
as ofP+Q+P
. This optimizes the one-time line precomputation for KZG in gnark-crypto, but most importantly matches gnark in-circuit implementation. This is now important since after Consensys/gnark#1143 we need to have the exact same lines so that the witness residue is the same.Type of change
How has this been tested?
pairing tests pass.
How has this been benchmarked?
In gnark-crypto, only the lines precompuation should be affected (faster) but it's just a one-time computation.
Checklist:
golangci-lint
does not output errors locally