Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ftrace errors #137

Merged
merged 3 commits into from
May 5, 2020
Merged

Fix ftrace errors #137

merged 3 commits into from
May 5, 2020

Conversation

tintinweb
Copy link
Member

also fixes #136

  • fix: TypeError: Cannot read property '1' of undefined - when resolving
    super()
  • update: track multiple usingFor instead of only the last one
    • uses the first one if multiple unsingFor overlap resolving to the
      same method
  • fix: Cannot read property '' of undefined - when resolving
    usingFor member access. this is a quick fix. we stop recursively resolving usingFor types at this point. could be improved but need to figure out how usingFor method mapping is used.
  • fix: Cannot read property ... - when assigning parentObject[string]

- fix: TypeError: Cannot read property '1' of undefined - when resolving
  super()
- update: track multiple usingFor <type> instead of only the last one
  - uses the first one if multiple unsingFor overlap resolving to the
    same method
- fix: Cannot read property '<contract>' of undefined - when resolving
  usingFor member access. this is a quick fix. we stop recursively
  resolving usingFor types now. could be improved.
- fix: Cannot read property ... - when assigning parentObject[string]
@tintinweb tintinweb requested a review from GNSPS April 1, 2020 20:41
Copy link
Collaborator

@GNSPS GNSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also think this fixes #136.

I will also try to apply the same improvements to the graph command in a decent timeframe and, if not, I will just accept the PR. 👍

@GNSPS
Copy link
Collaborator

GNSPS commented May 5, 2020

It's just coming with a month's delay! 😂 🙏

@GNSPS GNSPS merged commit abaa435 into develop May 5, 2020
@tintinweb tintinweb mentioned this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants