[Bellatrix]: Use block_header instead of block for block signing requests (BLOCK_V2) #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
Apr 28, 2022
...tance-tests/src/test/java/tech/pegasys/web3signer/dsl/utils/Eth2BlockSigningRequestUtil.java
Outdated
Show resolved
Hide resolved
...nce-tests/src/test/java/tech/pegasys/web3signer/tests/signing/SigningAcceptanceTestBase.java
Outdated
Show resolved
Hide resolved
.../main/java/tech/pegasys/web3signer/core/service/http/handlers/signing/eth2/BlockRequest.java
Outdated
Show resolved
Hide resolved
...pegasys/web3signer/core/service/http/handlers/signing/eth2/Eth2SignForIdentifierHandler.java
Outdated
Show resolved
Hide resolved
...pegasys/web3signer/core/service/http/handlers/signing/eth2/Eth2SignForIdentifierHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/resources/openapi-specs/eth2/signing/schemas.yaml
Outdated
Show resolved
Hide resolved
core/src/main/resources/openapi-specs/eth2/signing/schemas.yaml
Outdated
Show resolved
Hide resolved
|
Is this PR just for backward compatibility? |
usmansaleem
changed the title
jframe
approved these changes
May 9, 2022
|
@james-prysm This PR is to use optimized block signing request starting from Bellatrix fork. See #437 and #486 for more details as well. Feel free to reach out to the team on Discord. |
siladu
approved these changes
May 9, 2022
...-tests/src/test/java/tech/pegasys/web3signer/dsl/signer/runner/CmdLineParamsDefaultImpl.java
Show resolved
Hide resolved
...-tests/src/test/java/tech/pegasys/web3signer/tests/signing/KeyLoadAndSignAcceptanceTest.java
Show resolved
Hide resolved
...nce-tests/src/test/java/tech/pegasys/web3signer/tests/signing/SigningAcceptanceTestBase.java
Show resolved
Hide resolved
core/src/main/resources/openapi-specs/eth2/signing/schemas.yaml
Outdated
Show resolved
Hide resolved
|
@james-prysm This PR is partly to optimise the block signing so less data is needed to be passed in when signing block. It also means we can support the Bellatrix fork as we don't need to make additional changes to include ExecutionPayload with this change as long as are using the block_header with the body root in the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
For Bellatrix and onward forks, use
block_headerinstead ofblockfor block signing request (BLOCK_V2).block_headercontainsbody_rootinstead of complete beacon blockbodywhich significantly reduces the traffic between beacon client (such as Teku) and Web3Signer for block signing request.Either
block_headerorblockcan be used to calculate signing root by the Web3Signer. For backward compatibility withPHASE0andALTAIRforks, onlyblockis required; for Bellatrix and later forks, onlyblock_headeris required.Fixed Issue(s)
See #437
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog