You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As an implementor, I want the get_total_balance function implemented as per the spec so that Artemis is compliant with spec v0.4.0.
Acceptance Criteria
total_balance function in BeaconStateUtil is renamed to get_total_balance.
get_total_balance function returns the expected value (see PR adding return statement).
get_total_balance logic is largely duplicated in get_total_effective_balance. If this is a helper function that needs to continue to exist, it should be made private/default visibility, and all public calls should be to get_total_balance.
Description
As an implementor, I want the
get_total_balance
function implemented as per the spec so that Artemis is compliant with spec v0.4.0.Acceptance Criteria
total_balance
function inBeaconStateUtil
is renamed toget_total_balance
.get_total_balance
function returns the expected value (see PR adding return statement).get_total_balance
logic is largely duplicated inget_total_effective_balance
. If this is a helper function that needs to continue to exist, it should be made private/default visibility, and all public calls should be toget_total_balance
.Additional Information
get_total_balance
helper function ethereum/consensus-specs#567The text was updated successfully, but these errors were encountered: