Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename total_balance - (Spec PR #567, #569) #389

Closed
schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Closed

Rename total_balance - (Spec PR #567, #569) #389

schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Assignees
@schroedingerscode
Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

schroedingerscode commented Feb 26, 2019 •
edited
Loading

Description

As an implementor, I want the get_total_balance function implemented as per the spec so that Artemis is compliant with spec v0.4.0.

Acceptance Criteria

  • total_balance function in BeaconStateUtil is renamed to get_total_balance.
  • get_total_balance function returns the expected value (see PR adding return statement).
  • get_total_balance logic is largely duplicated in get_total_effective_balance. If this is a helper function that needs to continue to exist, it should be made private/default visibility, and all public calls should be to get_total_balance.
  • Modified function is adequately tested.

Additional Information
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 26, 2019
@schroedingerscode schroedingerscode changed the title Rename get_total_balance - (Spec PR #569) Rename total_balance - (Spec PR #569) Feb 26, 2019
@schroedingerscode schroedingerscode changed the title Rename total_balance - (Spec PR #569) Rename total_balance - (Spec PR #567, #569) Feb 26, 2019
@schroedingerscode schroedingerscode added the in progress 🚧 This issue or pull request is in progress label Mar 7, 2019
@schroedingerscode schroedingerscode self-assigned this Mar 7, 2019
@schroedingerscode schroedingerscode mentioned this issue Mar 7, 2019
Merged
2 tasks
@schroedingerscode
Copy link
Contributor Author

Closed by #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schroedingerscode schroedingerscode

Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@schroedingerscode