Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify logic in update_eth1_data matches the spec - (Spec PR #561) #397

Closed
schroedingerscode opened this issue Feb 26, 2019 · 3 comments
Closed

Verify logic in update_eth1_data matches the spec - (Spec PR #561) #397

schroedingerscode opened this issue Feb 26, 2019 · 3 comments
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want the per-block processing Eth1 Data update to be compliant with the spec so that Artemis performs as other clients expect.

Acceptance Criteria

  • If there exists an eth1_data_vote in states.eth1_data_votes for which eth1_data_vote.eth1_data == block.eth1_data (there will be at most one), set eth1_data_vote.vote_count += 1.
  • Otherwise, append to state.eth1_data_votes a new Eth1DataVote(eth1_data=block.eth1_data, vote_count=1).

Additional Information

See ethereum/consensus-specs#561
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 26, 2019
@schroedingerscode schroedingerscode changed the title Verify logic in update_eth1_data matches the spec - (See Spec PR #561) Verify logic in update_eth1_data matches the spec - (Spec PR #561) Feb 26, 2019
@vitorpy
Copy link
Contributor

vitorpy commented Feb 27, 2019

Working on it.

@vitorpy vitorpy mentioned this issue Feb 27, 2019
Merged
@schroedingerscode schroedingerscode added the in progress 🚧 This issue or pull request is in progress label Feb 28, 2019
@vitorpy
Copy link
Contributor

vitorpy commented Mar 11, 2019

I believe this was fixed by #408

@schroedingerscode
Copy link
Contributor Author

Yup, resolved by #408.

@schroedingerscode schroedingerscode removed the in progress 🚧 This issue or pull request is in progress label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
2 participants
@vitorpy @schroedingerscode