Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bounds checking in verify_bitfield - (Spec PR #573) #405

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Fix bounds checking in verify_bitfield - (Spec PR #573) #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f2afc3
Fix bounds checking in verify_bitfield - (Spec PR #573)
vitorpy Feb 27, 2019
fa7210c
Merge branch 'v0.4-integration' into verify_bitfield
schroedingerscode Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...atastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ public static int get_bitfield_bit(Bytes bitfield, int bitPosition) {
public static boolean verify_bitfield(Bytes bitfield, int committee_size) {
if (bitfield.size() != (committee_size + 7) / 8) return false;

for (int i = committee_size + 1; i < committee_size - committee_size % 8 + 8; i++) {
for (int i = committee_size; i < bitfield.bitLength() * 8; i++) {
if (get_bitfield_bit(bitfield, i) == 0b1) return false;
}
return true;
Expand Down